Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude skipped tests from report #129

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

dlockhart
Copy link
Member

Tests which were skipped (e.g. via grep) were showing up in the report but didn't have any "info". This excludes them.

We differentiate between tests that have no info BUT have an error, which means they failed because an exception was thrown during test execution. We render the error message where the diff would normally be:

Screenshot 2023-08-10 at 5 58 39 PM

@dlockhart dlockhart requested a review from a team as a code owner August 10, 2023 21:59
@dlockhart dlockhart merged commit fb449a8 into main Aug 11, 2023
1 check passed
@dlockhart dlockhart deleted the dlockhart/handle-grep branch August 11, 2023 12:56
@ghost
Copy link

ghost commented Aug 11, 2023

🎉 This PR is included in version 0.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants